Conversation
# Conflicts: # .gitignore # src/main/java/homework_1/Main.java
…re/IliaProkofev # Conflicts: # .gitignore
NikolaevArtem
removed
bug
|
|
||
| public class Main { | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
Good job! Nice interface, a lot of features (such as automatic ship placement, different game modes), comfortable to play, informative messages. I like the architecture, the code is readable and understandable. You show good knowledge of Java Core (missing Java 8 and some concepts of OOP).
To make it better: add automatic miss marks placement around a destroyed ship. Also, your code has a lot of static. It seems logical that if you don't care about having multiple objects of a class in your app (like Ship), then mark it static, but actually in this case it should be a singleton, and still dynamic. Static is rarely used in Java, mostly for constants and utils. And mostly your methods are void, which is also rare.
Approved!
| } catch (NoSuchMethodException e) { | ||
| temp = "Aristarch"; | ||
| this.age = 50; |
There was a problem hiding this comment.
opt: That's unexpected.. in catch clause you should handle error, not hide it and surely not insert some "magic" data
| //this.name = name; | ||
| this.age = age; | ||
| } catch (NoSuchMethodException e) { | ||
| name = "Aristarch"; |
There was a problem hiding this comment.
opt: here you put value for local var, not for class field
| import java.util.List; | ||
| import java.util.Scanner; | ||
|
|
||
| public class CustomFileReader { |
src/main/java/homework_6/map_problems_generator/MapProblemsGenerator.java
Show resolved
Hide resolved
NikolaevArtem
left a comment
NikolaevArtem
left a comment
There was a problem hiding this comment.
Good job! Except for minor fixes in HW_3 and HW_6, homework is done! Today on the lecture we will discuss these homework, as somehow many students have troubles with these
FIX HW_6
NikolaevArtem
added
HW_3
HW_6
and removed
readyForReview
4 participants
Completed homework_1